Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdk 5186 add custom email provider support #1065

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

acwest
Copy link

@acwest acwest commented Dec 20, 2024

Changes

This PR adds support for the custom email provider, and updates to the most recent auth0 api.

References

-https://auth0.com/docs/api/management/v2/emails/post-provider

@acwest acwest requested a review from a team as a code owner December 20, 2024 05:30
@tusharpandey13
Copy link
Contributor

Hi @acwest, noting that the PR is for the change "add custom email provider support",

  1. There are a lot of changes in files unrelated to this feature being pushed in this PR. If we are, in-fact updating these managers and methods, do we have tracking tickets/documentation for these changes? This PR should only contain changes related to this specific feature. To include specific endpoints, you can just replace those JSON nodes during generation process in sdks-oas.
  2. I see there are no unit-tests added for this feature. Please add unit tests for all the implemented endpoints, you can follow this file for your reference: self-service-profiles.test.ts. Please add the output of npm run test to your PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants