fix: use startsWith() instead of exact match comparison #1856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Updates the checks from a strict equals condition to a
startsWith()
, since the URL could have trailing slash📎 References
🎯 Testing
On the base
v4
branch, boot up a test app and go to/auth/login
, that should succeed. Then, onnext.config.ts
, set the config:It won't work because an exact comparison won't be matched. It'll check
/auth/login/
(the pathname on the middleware request) vs/auth/login
(what's currently used as the hardcoded route on the mapping object).