Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not throw when cookie delete fails #1305

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Should not throw when cookie delete fails #1305

merged 1 commit into from
Jul 21, 2023

Conversation

adamjmcgrath
Copy link
Contributor

📋 Changes

In addition to setting, clearing cookies should not throw when cookies.delete fails (when you're in a Server Component)

📎 References

#1235 (comment)

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner July 21, 2023 06:57
@vercel
Copy link

vercel bot commented Jul 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nextjs-auth0 ⬜️ Ignored (Inspect) Jul 21, 2023 6:57am

@adamjmcgrath adamjmcgrath merged commit 160a3cb into beta Jul 21, 2023
@adamjmcgrath adamjmcgrath deleted the warn-on-clear branch July 21, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants