Skip to content

Updated SetScope implementation in Options for Facebook and Apple Connection #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

duedares-rvj
Copy link
Member

@duedares-rvj duedares-rvj commented Mar 25, 2025

The SetScope implementation for Facebook and Apple connections treated the scope field as []interface{} whereas they are *string.
Oauth2, Okta and OIDC are other connections where scopes field in the Options block is of type *string
The rest of the connections have a different way of handling scopes.

🔧 Changes

Updated the implementation of SetScope for Facebook and Apple connection

📚 References

Addressed a customer ESD

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@duedares-rvj duedares-rvj requested a review from a team as a code owner March 25, 2025 10:44
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 95.54%. Comparing base (d837864) to head (1642744).

Files with missing lines Patch % Lines
management/connection.go 0.00% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
- Coverage   95.78%   95.54%   -0.24%     
==========================================
  Files          58       58              
  Lines       11335    11363      +28     
==========================================
  Hits        10857    10857              
- Misses        359      387      +28     
  Partials      119      119              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants