Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Improvements to CI Workflows #1128

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

evansims
Copy link
Member

@evansims evansims commented Aug 28, 2023

Changes

This pull request updates our continuous integration workflows. It (in part) mirrors improvements made to the Lock repository.

codeql.yml

  • Updated pull_request type triggers to use a narrower scope (avoids unnecessary runs) and apply to all branches.
  • Updated push branch triggers to be more concise (uses the v* wildcard.)
  • Added concurrency check (cancels redundant in-progress runs.)
  • Updated to skip unnecessary runs on Dependabot PRs and re-runs on merge group queues.

publish.yml

  • Fixed the NODE_VERSION environmental variable reference.

semgrep.yml

  • Updated to skip unnecessary runs on Dependabot PRs and re-runs on merge group queues.
  • Updated name to use "Check for Vulnerabilities" for clarity in branch protection filters.
  • Added concurrency check (cancels redundant in-progress runs.)

snyk.yml

  • Added workflow to trigger Snyk security checks.
    We previously used webhooks to trigger these checks, but this method is incompatible with GitHub's merge queue feature. This approach allows us to use the feature, as well as to autonomously run checks on a set schedule as we do in other repositories.

test.yml

  • Moves the Codecov coverage upload step into the unit test step (fixes coverage not being available during the build step.)

References

Updates based on internal feedback and conversations.

Testing

This pull request applies improvements to the continuous integration testing for the repository but does not add additional tests.

Checklist

@evansims evansims temporarily deployed to internal August 28, 2023 23:13 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal August 28, 2023 23:13 — with GitHub Actions Inactive
@evansims evansims added the review:small Small review label Aug 28, 2023
@evansims evansims temporarily deployed to internal August 28, 2023 23:17 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal August 28, 2023 23:18 — with GitHub Actions Inactive
@evansims evansims marked this pull request as ready for review August 28, 2023 23:45
@evansims evansims requested a review from a team as a code owner August 28, 2023 23:45
@evansims evansims added this pull request to the merge queue Aug 29, 2023
Merged via the queue into master with commit dc10bd1 Aug 29, 2023
12 checks passed
@evansims evansims deleted the test/ci-workflow-improvements branch August 29, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants