Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout correct ref in integration tests #608

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

ewanharris
Copy link
Contributor

@ewanharris ewanharris commented Oct 9, 2023

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

As we're using pull_request_target we need to specify the ref to checkout, also use npx to run pretty-quick in husky so that it doesn't need to be installed globally.

This is still going to fail as the issue at hand isn't fixed, but this will allow validating the fix in a PR

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • Auth0 Community post
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@ewanharris ewanharris requested a review from a team as a code owner October 9, 2023 13:04
@ewanharris ewanharris temporarily deployed to internal October 9, 2023 13:04 — with GitHub Actions Inactive
@ewanharris ewanharris temporarily deployed to internal October 9, 2023 13:04 — with GitHub Actions Inactive
@ewanharris ewanharris temporarily deployed to internal October 9, 2023 13:04 — with GitHub Actions Inactive
@ewanharris ewanharris temporarily deployed to internal October 9, 2023 13:04 — with GitHub Actions Inactive
@ewanharris ewanharris merged commit aa4bb90 into main Oct 10, 2023
13 of 14 checks passed
@ewanharris ewanharris deleted the ci/checkout-correct-ref branch October 10, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants