Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @types/react from 18.2.23 to 18.2.24 #599

Closed
wants to merge 8 commits into from
Closed

Bump @types/react from 18.2.23 to 18.2.24 #599

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d127888
Bump @types/react from 18.2.23 to 18.2.24
dependabot[bot] Oct 2, 2023
f328232
Share @types/react, remove router-dom types
ewanharris Oct 3, 2023
b50d56c
Merge branch 'main' into dependabot/npm_and_yarn/types/react-18.2.24
Widcket Oct 5, 2023
ce70daf
Convert to string
ewanharris Oct 6, 2023
036c180
Try and sync some more modules
ewanharris Oct 6, 2023
20592d1
Use component instead of element
ewanharris Oct 9, 2023
dd572d2
Revert toString for key in users
ewanharris Oct 9, 2023
0561ae2
Checkout correct ref
ewanharris Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions examples/cra-react-router/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,12 @@
"dependencies": {
"@auth0/auth0-react": "file:../..",
"@types/node": "^17.0.29",
"@types/react": "^18.0.8",
"@types/react-router-dom": "^5.3.3",
"@types/react": "file:../../node_modules/@types/react",
"react": "file:../../node_modules/react",
"react-dom": "file:../../node_modules/react-dom",
"react-router-dom": "^6.3.0",
"react-router-dom": "^6.16.0",
"react-scripts": "^5.0.1",
"typescript": "^4.6.3"
"typescript": "file:../../node_modules/typescript"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ewanharris Is this something we want to keep ? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to narrow down any potential differences in the build as I can't reproduce this locally at all. I think keeping the @types/react dependency in sync is worthwhile but maybe unnecessary for typescript

},
"scripts": {
"start": "react-scripts start",
Expand Down
4 changes: 2 additions & 2 deletions examples/cra-react-router/src/Users.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ export function Users() {
</tr>
</thead>
<tbody>
{users!.map(
{users.map(
({ name, email }: { name: string; email: string }, i: number) => (
<tr key={i}>
<tr key={i.toString()}>
<td>{name}</td>
<td>{email}</td>
</tr>
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading