Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent logout function types #548

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Fix inconsistent logout function types #548

merged 2 commits into from
Jun 23, 2023

Conversation

frederikprijck
Copy link
Member

Description

Logout is async, so it shouldn't be marked as void, but Promise<void>, like we already do in the provider.

References

Closes #545

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@frederikprijck frederikprijck requested a review from a team as a code owner June 23, 2023 10:57
@frederikprijck frederikprijck enabled auto-merge (squash) June 23, 2023 10:58
@frederikprijck frederikprijck merged commit 0af1dd4 into master Jun 23, 2023
@frederikprijck frederikprijck deleted the fix/545 branch June 23, 2023 11:06
@frederikprijck frederikprijck mentioned this pull request Jul 13, 2023
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript typing inconsistencies for the logout function
2 participants
@frederikprijck @adamjmcgrath