Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings during tests #547

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Fix warnings during tests #547

merged 2 commits into from
Jun 23, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Jun 23, 2023

Description

Fixes some warnings occuring during running the tests:

  • Not using act where we should use it.
  • We have our own warnings which polute the test output. So whenever a warning is expected, I mocked the console.warn function instead, and verify it's been called.
  • Reworked the test to verify a redirect message shows up now that act was added, which is async.

With the above changes, our console output when running the tests is a lot cleaner:

image

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@frederikprijck frederikprijck requested a review from a team as a code owner June 23, 2023 10:41
@frederikprijck frederikprijck merged commit c24ddea into master Jun 23, 2023
@frederikprijck frederikprijck deleted the chore/fix-test-warnings branch June 23, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants