Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
openUrl
parameter in bothloginWithRedirect
andlogout
on the browser version.openUrl
requires auth0-spa-js version2.0.1
or later.This is important to me due to the @microsoft/teams-js library necessary to do authentication inside microsoft teams, reference docs here
In short, it handles authentication in its own window.
My use case would be something similar to
🎯 Testing
2.0
to2.0.1
atauth0_flutter/example/web/index.html
loginWithRedirect
andlogout
functionsPossible concerns
While manual testing, you will also see two errors in the web console:
Error: Promise was rejected with a value of 'undefined'
TypeError: T.as is not a function
From my tests, this seems be comming out of the main
auth0-spa-js
library due to unhandled rejections, and doesn't affect the usage ofauth0_flutter
itself. Though it would require a deeper research on why it is happening.