refactor

aureliendavid · Oct 29, 2018 · 282ddf2 · 282ddf2
1 parent a83dad4
commit 282ddf2
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 194 deletions.
diff --git a/manifest.json b/manifest.json
@@ -2,7 +2,7 @@
 
   "manifest_version": 2,
   "name": "RSSPreview",
-  "version": "1.3",
+  "version": "2.0",
   "author": "Aurelien David",
   "homepage_url": "https://github.com/aureliendavid/rsspreview",
 
@@ -29,7 +29,7 @@
     }
   ],
 
-  "web_accessible_resources": ["preview.html", "preview.js", "preview.css", "rss.xsl", "icons/*.png"],
+  "web_accessible_resources": ["preview.css", "rss.xsl", "icons/*.png"],
 
   "permissions": ["<all_urls>", "webRequest", "webRequestBlocking"]
 

diff --git a/preview.html b/preview.html
diff --git a/preview.js b/preview.js
diff --git a/rsspreview.js b/rsspreview.js
@@ -136,6 +136,34 @@
   }
 
 
+  function extensionimages() {
+
+    var extimgs = document.getElementsByClassName("extImg");
+    for (var i = 0; i<extimgs.length; i++) {
+      extimgs[i].src = chrome.extension.getURL(extimgs[i].attributes['data-src'].nodeValue);
+    }
+
+  }
+
+  function makepreviewhtml() {
+
+    var doc = document.implementation.createHTMLDocument("");
+
+    var feedBody = doc.createElement("div");
+    feedBody.id = "feedBody";
+    doc.body.appendChild(feedBody);
+
+    var css = doc.createElement('link');
+    css.setAttribute('rel', 'stylesheet');
+    css.setAttribute('href', chrome.extension.getURL("preview.css"));
+    doc.head.appendChild(css);
+
+    return doc;
+
+
+  }
+
+
   function detect() {
 
     var rootNode = document.getRootNode().documentElement;
@@ -170,33 +198,6 @@
   }
 
 
-  function extensionimages() {
-
-    var extimgs = document.getElementsByClassName("extImg");
-    for (var i = 0; i<extimgs.length; i++) {
-      extimgs[i].src = chrome.extension.getURL(extimgs[i].attributes['data-src'].nodeValue);
-    }
-
-  }
-
-  function makepreviewhtml() {
-
-    var doc = document.implementation.createHTMLDocument("");
-
-    var feedBody = doc.createElement("div");
-    feedBody.id = "feedBody";
-    doc.body.appendChild(feedBody);
-
-    var css = doc.createElement('link');
-    css.setAttribute('rel', 'stylesheet');
-    css.setAttribute('href', chrome.extension.getURL("preview.css"));
-    doc.head.appendChild(css);
-
-    return doc;
-
-
-  }
-
   function main(feedNode) {
 
       var feed_url = window.location.href;
@@ -209,11 +210,6 @@
 
         // replace the content with the preview document
         document.replaceChild(document.importNode(preview.documentElement, true), document.documentElement);
-        window.document = preview;
-
-        console.log(preview);
-        console.log(window.document);
-        console.log(document);
 
         removeemptyenclosures();
         formatdescriptions();