Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin): fix vitest Windows issue with html file #2006

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

3cp
Copy link
Member

@3cp 3cp commented Jul 11, 2024

Solves some vitest+win32 issue identified in aurelia/new#108

@3cp 3cp requested a review from bigopon July 11, 2024 09:48
@3cp 3cp force-pushed the fix-vitest-win32 branch from ce4f5e6 to 9c4f54f Compare July 11, 2024 09:59
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.63%. Comparing base (3e78148) to head (9c4f54f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2006      +/-   ##
==========================================
- Coverage   88.63%   88.63%   -0.01%     
==========================================
  Files         279      279              
  Lines       23054    23054              
  Branches     5312     5312              
==========================================
- Hits        20434    20433       -1     
- Misses       2620     2621       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bigopon bigopon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, nice fix 👍

@bigopon bigopon merged commit 27ec4dd into master Jul 11, 2024
28 checks passed
@bigopon bigopon deleted the fix-vitest-win32 branch July 11, 2024 11:14
AureliaEffect pushed a commit that referenced this pull request Aug 8, 2024
2.0.0-beta.21 (2024-08-08)

**Features:**

* **ast:** support increment/decrement assign (#2004) ([4cfc0a3](4cfc0a3))

**Bug Fixes:**

* **state:** ensure all actions queued are called (#2023) ([062f398](062f398))
* **binding:** handle glitch (#2020) ([0f3dbee](0f3dbee))
* **router:** fix missing filter part for available endpoints (#2013) ([af7c252](af7c252))
* **router-lite:** element injection for routed view-model (#2012) ([b1508fb](b1508fb))
* **types:** bindable definitions (#2010) ([d81b471](d81b471))
* **task-queue:** fix timing issue (#2007) ([6777dba](6777dba))
* **router-lite:** location URL with no history and fragment routing (#2005) ([8a84b09](8a84b09))
* **vite-plugin:** fix vitest Windows issue with html file (#2006) ([27ec4dd](27ec4dd))

**Refactorings:**

* **task-queue:** remove 'reusable' param (#2008) ([54f43e8](54f43e8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants