move $basepath to factory ctor, add docblocks

src/Regex.php

@@ -52,6 +52,8 @@ class Regex
      *
      * @param string $path The requested URL path.
      *
+     * @param string $basepath A basepath to prefix to the route path.
+     *
      * @return bool
      *
      */

src/Route.php

@@ -238,6 +238,8 @@ public function __isset($key)
      * @param array $server A copy of $_SERVER so that this Route can check
      * against the server values.
      *
+     * @param string $basepath A basepath to prefix to the route path.
+     *
      * @return bool
      *
      */
@@ -263,6 +265,8 @@ public function isMatch($path, array $server, $basepath = null)
      * @param array $server A copy of $_SERVER so that this Route can check
      * against the server values.
      *
+     * @param string $basepath A basepath to prefix to the route path.
+     *
      * @return bool
      *
      */
@@ -391,6 +395,8 @@ protected function serverIsSecure($server)
      *
      * @param string $path The path to match against.
      *
+     * @param string $basepath A basepath to prefix to the route path.
+     *
      * @return bool True on a match, false if not.
      *
      */

src/Router.php

@@ -72,6 +72,13 @@ class Router
      */
     protected $failed_route = null;
 
+    /**
+     *
+     * A basepath to all routes.
+     *
+     * @var string
+     *
+     */
     protected $basepath;
 
     /**
@@ -82,6 +89,8 @@ class Router
      *
      * @param Generator $generator A URL path generator.
      *
+     * @param string $basepath A basepath to to all routes.
+     *
      */
     public function __construct(
         RouteCollection $routes,

src/RouterFactory.php

@@ -17,19 +17,40 @@
  */
 class RouterFactory
 {
+    /**
+     *
+     * A basepath to all routes.
+     *
+     * @var string
+     *
+     */
+    protected $basepath;
+
+    /**
+     *
+     * Constructor.
+     *
+     * @param string $basepath A basepath to to all routes.
+     *
+     */
+    public function __construct($basepath = null)
+    {
+        $this->basepath = $basepath;
+    }
+
     /**
      *
      * Returns a new Router instance.
      *
      * @return Router
      *
      */
-    public function newInstance($basepath = null)
+    public function newInstance()
     {
         return new Router(
             new RouteCollection(new RouteFactory),
             new Generator,
-            $basepath
+            $this->basepath
         );
     }
 }

tests/RouterTest.php

@@ -13,8 +13,8 @@ protected function setUp()
 
     protected function newRouter($basepath = null)
     {
-        $factory = new RouterFactory;
-        return $factory->newInstance($basepath);
+        $factory = new RouterFactory($basepath);
+        return $factory->newInstance();
     }
 
     protected function assertIsRoute($actual)