✨ Add unassessed risk type and exit early for app risk status calcula…

…tion (konveyor#623) https://issues.redhat.com/browse/MTA-2308 Signed-off-by: Ian Bolton <[email protected]>
aufi · Apr 5, 2024 · 94330e1 · 94330e1
1 parent 5b39e71
commit 94330e1
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 24 deletions.
diff --git a/api/application.go b/api/application.go
@@ -1136,7 +1136,7 @@ func (r *Application) With(m *model.Application, tags []model.ApplicationTag) {
 		})
 		r.Effort = m.Analyses[len(m.Analyses)-1].Effort
 	}
-	r.Risk = assessment.RiskUnknown
+	r.Risk = assessment.RiskUnassessed
 }
 
 // WithVirtualTags updates the resource with tags derived from assessments.

diff --git a/api/archetype.go b/api/archetype.go
@@ -385,7 +385,7 @@ func (r *Archetype) With(m *model.Archetype) {
 		ref.With(m.Review.ID, "")
 		r.Review = ref
 	}
-	r.Risk = assessment.RiskUnknown
+	r.Risk = assessment.RiskUnassessed
 }
 
 // WithResolver uses an ArchetypeResolver to update the resource with

diff --git a/assessment/pkg.go b/assessment/pkg.go
@@ -8,10 +8,11 @@ import (
 
 // Assessment risk
 const (
-	RiskUnknown = "unknown"
-	RiskRed     = "red"
-	RiskYellow  = "yellow"
-	RiskGreen   = "green"
+	RiskUnassessed = "unassessed"
+	RiskUnknown    = "unknown"
+	RiskRed        = "red"
+	RiskYellow     = "yellow"
+	RiskGreen      = "green"
 )
 
 // Assessment status
@@ -43,26 +44,23 @@ const (
 
 // Risk returns the single highest risk score for a group of assessments.
 func Risk(assessments []Assessment) (risk string) {
-	risk = RiskUnknown
+	// Return "unassessed" immediately if there are no assessments
 	if len(assessments) == 0 {
-		return
+		return RiskUnassessed
 	}
-	red := 0
-	yellow := 0
-	unknown := 0
-	green := 0
-	if len(assessments) > 0 {
-		for _, a := range assessments {
-			switch a.Risk() {
-			case RiskRed:
-				red++
-			case RiskYellow:
-				yellow++
-			case RiskGreen:
-				green++
-			default:
-				unknown++
-			}
+
+	red, yellow, unknown, green := 0, 0, 0, 0
+
+	for _, a := range assessments {
+		switch a.Risk() {
+		case RiskRed:
+			red++
+		case RiskYellow:
+			yellow++
+		case RiskGreen:
+			green++
+		default:
+			unknown++
 		}
 	}