Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excluded sklearn (not used) #124

Closed
wants to merge 1 commit into from
Closed

Excluded sklearn (not used) #124

wants to merge 1 commit into from

Conversation

theScriptingEngineer
Copy link
Collaborator

Removed references to sklearn as these seem not to be used
Added check for windll
Removed string concat for folder manipulations

Excluded sklearn (not used)
02ffcdb 
Added check for windll
Removed string concat for folder manipulatins
@theScriptingEngineer theScriptingEngineer self-assigned this Feb 27, 2023
@theScriptingEngineer theScriptingEngineer linked an issue Feb 27, 2023 that may be closed by this pull request
Loading built-in section #119
Open
@theScriptingEngineer
Copy link
Collaborator Author

I also did a pip freeze so the requirements file has the external modules, including version.

@audunarn
Copy link
Owner

audunarn commented Mar 1, 2023

Hi, sklearn is needed to load the files under /any_files/ml_files/
If these are not loaded the algorithm running machine learning PULS will not work.

@theScriptingEngineer
Copy link
Collaborator Author

Check.
I'll have a look at it later. For now I'll close this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audunarn audunarn Awaiting requested review from audunarn

Assignees

@theScriptingEngineer theScriptingEngineer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading built-in section
2 participants
@theScriptingEngineer @audunarn