AV-565, AV-1234, AV-1233: Update Dependencies #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Localization Summary
|
📦 Next.js Bundle Analysis for audioverse-nextThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Ninety-four Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Accessibility Issues
|
narthur
requested changes
Aug 30, 2024
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable react/prop-types */ | |||
There was a problem hiding this comment.
Let's see if we can avoid this ignore by adding : Props on line 37
| @@ -27,6 +27,7 @@ export default function FeaturedTeachings(): JSX.Element { | |||
| Card={(p: { node: CardRecordingFragment }) => ( | |||
| <CardRecording recording={p.node} /> | |||
| )} | |||
| showLoading | |||
There was a problem hiding this comment.
This should be gone with the update to the continue listening pr, yes?
| ? (analytics.track('Search', { term }), setLastTerm(term)) | ||
| : ''; | ||
| setIsFocused(false); | ||
| return lastTerm != term && term != '' |
There was a problem hiding this comment.
Failed to notice that this lambda doesn't return the result of its last expression.
jakecoble
force-pushed
the
dependencies-update
branch
from
eb4f75d
to
33818a9
Compare
|
@jakecoble Looks like the accessibility scan found a bunch of new instances of this error: WCAG2AA.Principle2.Guideline2_4.2_4_1.H64.1 https://squizlabs.github.io/HTML_CodeSniffer/Standards/WCAG2/ "Iframe element requires a non-empty title attribute that identifies the frame." |
jakecoble
force-pushed
the
dependencies-update
branch
from
d803807
to
a86a6ed
Compare
jakecoble
force-pushed
the
dependencies-update
branch
from
a86a6ed
to
e137df7
Compare
jakecoble
force-pushed
the
dependencies-update
branch
from
e137df7
to
f13c91c
Compare
jakecoble
force-pushed
the
dependencies-update
branch
from
f13c91c
to
1ee8f05
Compare
jakecoble
force-pushed
the
dependencies-update
branch
from
1ee8f05
to
798b3ec
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
narthur
changed the title
alangumer
requested changes
Oct 16, 2024
src/components/organisms/cardSlider/section/continueListening.tsx
Outdated
Show resolved
Hide resolved
src/components/organisms/cardSlider/section/continueListening.tsx
Outdated
Show resolved
Hide resolved
src/components/organisms/cardSlider/section/trendingTeachings.tsx
Outdated
Show resolved
Hide resolved
src/components/organisms/cardSlider/section/trendingTeachings.tsx
Outdated
Show resolved
Hide resolved
alangumer
requested changes
Oct 23, 2024
alangumer
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories: