Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last fixes for Audacious 4.4 #1399

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Last fixes for Audacious 4.4 #1399

merged 3 commits into from
Jun 5, 2024

Conversation

radioactiveman
Copy link
Member

@radioactiveman radioactiveman commented Jun 3, 2024 •
edited
Loading

See the commit messages for more details.

Is the infopopup approach acceptable for you, John? And could you please test it on Windows?
On X11 is has no effect while fixing the wrong popup position on Wayland.

P.S. My plan is to release Audacious 4.4 in the next days, probably this weekend, after updating all translations. Any objections?

@radioactiveman
tests: Simplify pkg-config call
7a958b5
@radioactiveman
audqt: Require and check for Qt SVG module
f0fccff 
If not installed, Audacious does neither show
SVG icons nor our logo in the about dialog.

It also gives package maintainers a clear indicator
that Audacious depends on it at runtime.
@jlindgren90
Copy link
Member

I think it would be better to pass the parent window explicitly to the infopopup_show calls. We can add function overloads for this. The infopopup can also be shown (as you mentioned) from the skinned playlist window, and from the status icon (even when the main window is hidden). So using the mainwindow as the transient parent is not always correct.

@radioactiveman
audgui: Allow to specify a parent window for infopopup
49fd36b 
Without a parent, the popup is always shown at the top left corner
instead of near the cursor (when using Wayland). It also avoids
the following warning:

"Window 0xabcd is a temporary window without parent,
 application will not be able to position it on screen."

See also: https://docs.gtk.org/gtk3/method.Window.set_transient_for.html
@radioactiveman
Copy link
Member Author

I think it would be better to pass the parent window explicitly to the infopopup_show calls. We can add function overloads for this. The infopopup can also be shown (as you mentioned) from the skinned playlist window, and from the status icon (even when the main window is hidden). So using the mainwindow as the transient parent is not always correct.

Good point, I didn't think about the statusicon plugin. Updated accordingly, is it what you intended?

@radioactiveman radioactiveman mentioned this pull request Jun 5, 2024
Merged
@jlindgren90
Copy link
Member

Looks good. Thanks!

@jlindgren90 jlindgren90 merged commit c684358 into audacious-media-player:master Jun 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlindgren90 jlindgren90 Awaiting requested review from jlindgren90

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radioactiveman @jlindgren90