add check for writable parent dir templates/

atutor · Feb 3, 2018 · 8092427 · 8092427
1 parent ff5d693
commit 8092427
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/template_editor/edit_layout.php b/template_editor/edit_layout.php
@@ -41,7 +41,7 @@
     header('Location: index.php');
     exit;
 }
-if(!is_writable($_SERVER['DOCUMENT_ROOT'].$_base_path.'templates/'.$type)){
+if(!is_writable($_SERVER['DOCUMENT_ROOT'].$_base_path.'templates/'.$type) || !is_writable($_SERVER['DOCUMENT_ROOT'].$_base_path.'templates/')){
     $msg->addWarning('TEMPLATE_DIR_NOT_WRITABLE');
     $temp_unwritable = TRUE;
 }else{

diff --git a/template_editor/edit_page.php b/template_editor/edit_page.php
@@ -31,7 +31,7 @@
 $type = "page_templates";
 $template=$_GET['temp'];
 // non existing template name
-if(!is_writable($_SERVER['DOCUMENT_ROOT'].$_base_path.'templates/'.$type)){
+if(!is_writable($_SERVER['DOCUMENT_ROOT'].$_base_path.'templates/'.$type)|| !is_writable($_SERVER['DOCUMENT_ROOT'].$_base_path.'templates/')){
     $msg->addWarning('TEMPLATE_DIR_NOT_WRITABLE');
     $temp_unwritable = TRUE;
 }else{

diff --git a/template_editor/edit_structure.php b/template_editor/edit_structure.php
@@ -32,7 +32,7 @@
     Header('Location: index.php');
     exit;
 }
-if(!is_writable($_SERVER['DOCUMENT_ROOT'].$_base_path.'templates/'.$type)){
+if(!is_writable($_SERVER['DOCUMENT_ROOT'].$_base_path.'templates/'.$type) || !is_writable($_SERVER['DOCUMENT_ROOT'].$_base_path.'templates/')){
     $msg->addWarning('TEMPLATE_DIR_NOT_WRITABLE');
     $temp_unwritable = TRUE;
 }else{