Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rust to 1.80.1 #2362

Merged
merged 1 commit into from
Aug 14, 2024
Merged

chore: update rust to 1.80.1 #2362

merged 1 commit into from
Aug 14, 2024

Conversation

eopb
Copy link
Contributor

@eopb eopb commented Aug 13, 2024

fixes #2360

https://blog.rust-lang.org/2024/08/08/Rust-1.80.1.html

1.80.1 fixes a fairly nasty miscompilation, but that's not my motivation for opening this PR.

If I'm understanding correctly, because the rust patch version was not specified in rust-toolchain.toml, nix automatically upgraded to the new version. This broke the hash in flake.nix causing the flake to fail to build. Making this upgrade to 1.80.1 explicit, fixes this issue.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

fixes atuinsh#2360

https://blog.rust-lang.org/2024/08/08/Rust-1.80.1.html

`1.80.1` fixes a fairly nasty miscompilation, but that's not my motivation for opening this PR.

If I'm understanding correctly, because the rust patch version was not specified in `rust-toolchain.toml`, nix automatically upgraded to the new version. This broke the hash in `flake.nix` causing the flake to fail to build. Making this upgrade to `1.80.1` explicit, fixes this issue.
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

Tbh it might be good to try and automate some more of the nix stuff. I'd like to avoid specifying the patch release in future

@ellie ellie merged commit d264840 into atuinsh:main Aug 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot install on NixOS
2 participants