Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add env ATUIN_TEST_LOCAL_TIMEOUT to control test timeout of SQLite #2337

Merged
merged 2 commits into from
Aug 5, 2024
Merged

test: add env ATUIN_TEST_LOCAL_TIMEOUT to control test timeout of SQLite #2337

merged 2 commits into from
Aug 5, 2024

Commits on Aug 2, 2024

  1. test: add env ATUIN_TEST_LOCAL_TIMEOUT to control test timeout of SQLite 

    This make it possible to control the timeout of SQLite operations in
test. And ATUIN_TEST_LOCAL_TIMEOUT defaults to the default local_timeout,
which is actually used in the client. Instead of a small timeout (0.1),
this change makes the test less likely to fail and better imitate the
default behavior.

SQLite operation timeout was first introduced from atuinsh#1590, including
connection and store timeout. The env ATUIN_TEST_SQLITE_STORE_TIMEOUT
which added by atuinsh#1703 only specify the store timeout. This commit doesn't
deprecate ATUIN_TEST_SQLITE_STORE_TIMEOUT, but control it by setting its
default to the new env ATUIN_TEST_LOCAL_TIMEOUT.
    @jaxvanyang
    jaxvanyang committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4d88611 View commit details
    Browse the repository at this point in the history

  2. test!: replace ATUIN_TEST_SQLITE_STORE_TIMEOUT with ATUIN_TEST_LOCAL_… 

    …TIMEOUT

This deprecate ATUIN_TEST_SQLITE_STORE_TIMEOUT for simplicity as the new
env ATUIN_TEST_LOCAL_TIMEOUT can control both connection and store
timeout of SQLite in test. Details see 4d88611.

Revert: atuinsh#1703.
    @jaxvanyang
    jaxvanyang committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    687185c View commit details
    Browse the repository at this point in the history