Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should have spotted this when I got rid of rmp-serde, but I missed it. The original
rmp_serde::to_vec(key.as_slice())
code didn't convert towrite_bin
, but ratherwrite_array_len
and multiplewrite_uint
calls.Thankfully this hasn't made it into a release yet, and in my testing, the incorrect code just wouldn't parse the key, rather than encrypting anything bogus. No harm done.
I never want to use a hidden encoding scheme ever again.