Configurable log level

[Roy-Orbison]

Backwards-compatible, and only takes precedence over the fallback value.

Closes #498.

This code is untested but also a pretty minor change. I'm happy to modify it.

[unode]

Hi Roy thanks for this PR.

It looks to me that instead of introducing LOG_LEVEL with a default of None we should instead make it logging.INFO and simplify the third line of the code that configures logging (line 86).

I also see that LOG_LEVEL = logging.DEBUG might be redundant with or remove the need for DEBUG = True.
This is something we could mark as deprecated and a candidate for future removal.
Could you include this in your PR?

settings.DEBUG is only used in two locations in the mmpy_bot code so the need for backwards compatibility is slim.

[Roy-Orbison]

Yes, it was intended to deprecate DEBUG. I didn't expect that many people have it enabled in production, but some might in development, or may uncomment it as needed to diagnose issues, and this shouldn't break those cases. I suppose this would necessitate a minor version bump.

[Roy-Orbison]

I also noticed docs/settings.py doesn't seem to be referenced anywhere. The ReadTheDocs pages refer to mmpy_bot/settings.py instead.

[unode]

Please exclude docs/settings.py from the PR (I've included suggestions in the review for your convenience) as the DEBUG there is for an unrelated purpose that I believe is, in any case, no longer being used.

[unode]

I also noticed docs/settings.py doesn't seem to be referenced anywhere. The ReadTheDocs pages refer to mmpy_bot/settings.py instead.

That's a very good point. I don't think there's anything Django specific there as docs are handled by Sphinx but I'll wait for @attzonko's input on it. At birds-eye it looks like some of those files are leftovers from the past and should be removed.

PS: once the above changes are included, I would say is ready to merge. Thank you for this contribution.

[attzonko]

Yeah I have not really poked in the docs folder much. I am sure there is some leftovers in there that could be cleaned up.

Adressed

[unode]

Seems like black is still failing on code style.
Can you make the linter happy?

[Roy-Orbison]

Adjusted using the playground. I think it's slightly less readable, myself, but Black did not like a line length.

[codeclimate]

Code Climate has analyzed commit bc807f1 and detected 0 issues on this pull request.

View more on Code Climate.

[unode]

Merging. There was an integration test failure but I think it was unrelated to the changes.