Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement #160 #161 (Make phone numbers and email addresses interactive) #178

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

Ninad07
Copy link
Contributor

@Ninad07 Ninad07 commented Mar 8, 2022

What I did
Made phone number and email address field interactive by opening the respective phone/messagin/mail app the user selects, after tapping on the phone number and email address field.

How I did it
I used a flutter package url_launcher for the purpose. In the already provided GestureDetector widget for the phone number field (custom_card.dart), in the onTap function, I used the prebuilt methods from the package to open the phone and messaging or email app with the phone number/email precomposed as soon as the user selects the app

How to verify it
For verification, just tap on the phone number of the user, whose profile page you are on, currently. It opens an intent bottom sheet asking us to select the respective phone number or messaging app we want to use (get redirected to). Select any. It will open the selected app and we can see the recipient's field already composed with the same phone number.

Description for the changelog
Made the phone number and email address field interactive by providing phone number, messaging and email app options for the users to select and get redirected to the selected app.

@tinashe404
Copy link
Member

@sarika01 @nitesh2599 Please review this

@nitesh2599
Copy link
Contributor

@Ninad07 This is not working on iOS simulator.

@Ninad07
Copy link
Contributor Author

Ninad07 commented Mar 11, 2022

Alright. I'll recheck

@Ninad07 Ninad07 changed the title Enhancement #160 (Make phone numbers interactive) Enhancement #160 #161 (Make phone numbers and email addresses interactive) Mar 11, 2022
@Ninad07
Copy link
Contributor Author

Ninad07 commented Mar 11, 2022

@nitesh2599 Regarding IOS, I checked through Flutter Inspector and it seemed to work. Moreover, the package url_launcher supports both the platforms. I have still made another commit combining issue #160 and #161. Can you please check again once?

@Ninad07
Copy link
Contributor Author

Ninad07 commented Mar 13, 2022

@nitesh2599
Copy link
Contributor

Sorry @Ninad07 , but it's not working on my devices.

@yahu1031 @tinashe404 Can any of you please test this (on IOS), and let me know if it is working for anyone of you ?

sonle-geekyants pushed a commit that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants