Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message to use new lexicon #275

Open
cpswan opened this issue Jan 24, 2023 · 3 comments
Open

Update error message to use new lexicon #275

cpswan opened this issue Jan 24, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@cpswan
Copy link
Member

cpswan commented Jan 24, 2023

Is your feature request related to a problem? Please describe.

The present error message for AT0007 in packages/at_commons/lib/src/exception/error_message.dart is Secondary Server not found.

Describe the solution you'd like

Use atServer not found. instead

Describe alternatives you've considered

We might have to leave this be (or leave until we're doing other breaking changes).

Additional context

Could this break anything? Do we expect clients to look for the full error string or just the error code?

@cpswan
Copy link
Member Author

cpswan commented Feb 20, 2023

@murali-shris I just realised we need to get somebody assigned to do the work on this, as I don't expect @CynthiaPeter to do that.

@cpswan cpswan assigned gkc and murali-shris and unassigned CynthiaPeter Mar 6, 2023
@cpswan
Copy link
Member Author

cpswan commented Mar 6, 2023

Adding @gkc and bumping to PR57

@gkc
Copy link
Contributor

gkc commented Mar 8, 2023

Also need to update at_lookup_impl.dart in at_libraries

  static String getNotFoundExceptionMessage(String atSign) {
    return 'Unable to find secondary address for atSign:$atSign';
  }

and various other places https://github.com/search?q=org%3Aatsign-foundation+%22Secondary+server+not+found%22&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants