docs: Updated the documentation to use new lexicon - Fixes #28 #34
Conversation
There was a problem hiding this comment.
Thanks @CynthiaPeter mostly LGTM. Just a few tweaks before this can be merged.
|
|
||
|
|
||
| ```error:AT0007-Secondary Server not found.``` | ||
| ```error:AT0007-atServer not found.``` |
There was a problem hiding this comment.
The code hasn't been updated yet, so it still says Secondary server not found
There was a problem hiding this comment.
I've raised atsign-foundation/at_tools#275 to get this changed, but that might not happen straight away.
There was a problem hiding this comment.
The docs here need to reflect the actual error message until it gets fixed in the code.
|
|
||
| ```error:AT0007-Secondary Server not found.``` | ||
| ```error:AT0007-atServer not found.``` |
|
@CynthiaPeter when do you expect to be able to make the changes I requested a couple of weeks ago? |
|
Oh, I missed this.
I’ll get to it now.
Apologies.
On Mon, 6 Feb 2023 at 17:19, Chris Swan ***@***.***> wrote:
@CynthiaPeter <https://github.com/CynthiaPeter> when do you expect to be
able to make the changes I requested a couple of weeks ago?
—
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIAG7VFXAI4QJ6NPGNNUFNDWWEQB5ANCNFSM6AAAAAAUFKFS6I>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Cynthia Peter,*
*Twitter* : ***@***.****
*LinkedIn: Cynthia Peter <https://www.linkedin.com/in/cynthiapeter/>*
|
|
|
||
|
|
||
| ```error:AT0007-Secondary Server not found.``` | ||
| ```error:AT0007-atServer not found.``` |
There was a problem hiding this comment.
The docs here need to reflect the actual error message until it gets fixed in the code.
|
|
||
| ```error:AT0007-Secondary Server not found.``` | ||
| ```error:AT0007-atServer not found.``` |
We'll implement changes for lines 762 and 734 when the actual codes have been updated. If this is something I can update, let me know how I can help.
|
Thanks @CynthiaPeter :) |
|
Thank you, @cpswan. I'm sorry for missing the feedback and dragging the PR for weeks. |
- What I did
This PR fixes issues with #28
- How I did it
I updated the terms with new lexicons.
@platform to atPlatform.
@sign to atSign
secondary server to atServer
root server to atDirectory
- How to verify it
- Description for the changelog
Updated the documentation to use the new lexicon.