feat: introduce at_signing_algo and hashing_algo in at_auth_request and at_onboarding_request #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murali-shris
requested changes
Jul 16, 2024
# Conflicts: # packages/at_auth/lib/src/at_auth_impl.dart
…d/authenticate in at_auth
|
A functional test has been added but skipped for now. It will be unskipped once atsign-foundation/at_server#2045 has been resolved |
|
@sitaram-kalluri @srieteja atsign-foundation/at_server#2045 has been resolved - let's unskip the test and get this PR reviewed and merged |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #602
- What I did
- How to verify it
- Description for the changelog
feat: introduce at_signing_algo and hashing_algo in at_auth_request and at_onboarding_request