Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace encryption methods/key generation from EncryptionUtil with AtChops #1209

Merged
merged 6 commits into from
Jan 16, 2024

Conversation

murali-shris
Copy link
Member

- What I did

  • Replace encryption related methods used from EncryptionUtils with AtChops method
  • removed unnecessary exception/code blocks
    - How I did it
  • Removed AtKeyException block in shared_key_decryption.dart since AtChops decrypt method doesn't throw this exception
  • Removed getting currentAtSignEncryptionPublicKey in abstract_atkey_encryption.dart since at_chops instance will have the encryption public key set at instantiation.
  • Replace EncryptionUtil.encryptKey with AtChops.encryptString in abstract_atkey_encryption.dart, self_key_encryption.dart, shared_key_encryption.dart
  • Added unit test at_chops_encryption_util_compatibility_test.dart to verify compatibilty check between values encrypted with EncryptionUtil and decrypted using AtChops and vice versa.
  • Removed couple of tests from encryption_service_test.dart since they are covered in new tests
    - How to verify it
  • unit and functional tests should pass
  • @purnimavenkatasubbu Verified data sharing in atmospherePro and atBuzz apps.

@murali-shris
Copy link
Member Author

murali-shris commented Jan 16, 2024

This pull request addresses two sub tasks in #1145

  1. self_key_encryption.dart,shared_key_encryption.dart
    EncryptionUtil.encryptValue
    replace with at_chops.encryptString
  2. abstract_atkey_encryption.dart --> createMyCopyOfSharedSymmetricKey
    EncryptionUtil.generateAESKey() - replace with AtChopUtil

@murali-shris murali-shris changed the title feat: Replace encryption methods with atchops feat: Replace encryption methods/key generation from EncryptionUtil with AtChops Jan 16, 2024
@murali-shris murali-shris marked this pull request as ready for review January 16, 2024 13:35
@gkc gkc merged commit b16337d into trunk Jan 16, 2024
8 checks passed
@gkc gkc deleted the replace_encryption_methods_with_atchops branch January 16, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants