Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: option to delete local secondary when remote has been reset #1033

Open
wants to merge 40 commits into
base: trunk
Choose a base branch
from
Open

fix: option to delete local secondary when remote has been reset #1033

wants to merge 40 commits into from

Conversation

srieteja
Copy link
Contributor

@srieteja srieteja commented May 15, 2023 •
edited
Loading

Closes #900
- What I did

  • Introduce a method that checks if the remote secondary has been reset; returns true if the remote secondary has been reset.
  • Introduce a method to delete local storage.
  • Introduce a method to close instances of commitLog and hive in the Storage manager

- How I did it

  • Fetch AT_ENCRYPTION_PUB_KEY from remote secondary and local secondary and if they are not the same, this is considered a reset.
  • Additional method has been introduced [deleteLocalSecondaryStorageWithConsent()] which takes a consent flag and deletes the local files belonging to the current atsign.

- How to verify it

  • unit tests present in at_client_impl_test.dart

- Description for the changelog

fix: option to delete local secondary when remote has been reset

@srieteja srieteja marked this pull request as draft May 15, 2023 09:58
@srieteja srieteja mentioned this pull request Jul 9, 2023
Open
srieteja and others added 13 commits July 19, 2023 12:33
@srieteja
refactor: merge methods _deleteHiveStorage() and _deleteCommitLogStorage
191dfc0
@srieteja
Merge branch 'trunk' into reset_local_secondary
b2a8d55
@srieteja
refactor: isSecondaryReset() now returns Future<bool>
bf92190
@srieteja
feat: introduce deleteLocalStorageWithConsent in at_client_spec
216eec8
@srieteja
feat: deleteLocalStorageWithConsent now fetches hiveStoragePath and c…
6b0efb8 
…ommitLogStoragePath from AtClientPrefs
@srieteja
Merge remote-tracking branch 'origin/reset_local_secondary' into rese…
09c1a40 
…t_local_secondary
@srieteja
test: modify test according to new changes
eccd624
@srieteja
test: modify test according to new changes
ac018d0
@srieteja
tests: fix unit tests
f7349c9
@srieteja
feat: introduce and consume menthod to stop instances of commitLog an…
80e5ab9 
…d hive
@srieteja
Update pubspec.yaml
4263b82
@srieteja
Update pubspec.yaml
17e346f
@srieteja
refactor: introduce option to close storage manager
a8ec40e
@srieteja srieteja marked this pull request as ready for review August 17, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murali-shris murali-shris murali-shris left review comments

@sitaram-kalluri sitaram-kalluri Awaiting requested review from sitaram-kalluri

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trying to connect with the wrong atKeys results in a lot of errors
2 participants
@srieteja @murali-shris