Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test for metadata of device info key format from noports #404

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

XavierChanth
Copy link
Member

@XavierChanth XavierChanth commented Sep 20, 2024

- What I did

  • Added a metadata unit test which tests the same metadata fields as NoPort's device_info key

- How I did it

- How to verify it

Unit tests pass

- Description for the changelog
test: add unit test for metadata of device info key format from noports

Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for couple of typos

packages/atclient/tests/test_atkey_metadata.c Outdated Show resolved Hide resolved
packages/atclient/tests/test_atkey_metadata.c Outdated Show resolved Hide resolved
@gkc gkc merged commit a5d273f into trunk Sep 20, 2024
7 checks passed
@gkc gkc deleted the xc-cleanup-metadata branch September 20, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants