-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #223 Test code clean up #248
Conversation
tests/testthat/test-metadata.R
Outdated
@@ -759,10 +759,12 @@ test_that("xportr_*: Domain is kept in between calls", { | |||
# end | |||
|
|||
test_that("`xportr_metadata()` results match traditional results", { | |||
|
|||
if (requireNamespace("magrittr", quietly = TRUE)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{magrittr}
is on Imports
in the DESCRIPTION
file.
We can safely assume it is installed and remove all of these requreNamespace("magrittr", ...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you use the admiraldev add-in for this? If not, maybe we should look into making that a standalone tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need the haven and readxl packages in these tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can they be removed so the lintr becomes happy again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did use admiraldev add-in |
DESCRIPTION
Outdated
@@ -36,13 +36,13 @@ Imports: | |||
readr, | |||
rlang (>= 0.4.10), | |||
stringr (>= 1.4.0), | |||
tidyselect | |||
tidyselect, | |||
readxl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where are we using this? how come it got moved from Suggest to Imports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im weary to move readxl to Imports? why are we doing this?
Hi @bms63 it was given me a dependency error in the R CMD check, but i made some slight updates. It seems to be working great now and readxl is back to suggest |
Thanks for organizing and cleaning up our test code. Much nicer!!! |
Thank you for your Pull Request!
We have developed a Pull Request template to aid you and our reviewers. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the xportr codebase remains robust and consistent.
The scope of
{xportr}
{xportr}
's scope is to enable R users to write out submission compliantxpt
files that can be delivered to a Health Authority or to downstream validation software programs. We see labels, lengths, types, ordering and formats from a dataset specification object (SDTM and ADaM) as being our primary focus. We also see messaging and warnings to users around applying information from the specification file as a primary focus. Please make sure your Pull Request meets this scope of {xportr}. If your Pull Request moves beyond this scope, please get in touch with the{xportr}
team on slack or create an issue to discuss.Please check off each task box as an acknowledgment that you completed the task. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.Changes Description
(descriptions of changes)
Task List
styler
package and functions to style files accordingly.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelypkgdown::build_site()
and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page.NEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)NEWS.md
entry should go under the# xportr development version
section. Don't worry about updating the version because it will be auto-updated using thevbump.yaml
CI.