Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #206 Add agency standards vignette #236

Merged
merged 8 commits into from
Mar 7, 2024

docs: add suggestions from @bms63

1b22b33
Select commit
Loading
Failed to load commit list.
Merged

Closes #206 Add agency standards vignette #236

docs: add suggestions from @bms63
1b22b33
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-03-07 01:45:19 ago

0 / 15 tasks completed

15 tasks still to be completed

Details

Required Tasks

Task Status
The spirit of xportr is met in your Pull Request Incomplete
Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update) Incomplete
Summary of changes filled out in the above Changes Description. Can be removed or left blank if changes are minor/self-explanatory. Incomplete
Code is formatted according to the tidyverse style guide. Use styler package and functions to style files accordingly. Incomplete
New functions or arguments follow established convention found in the Wiki. Incomplete
Updated relevant unit tests or have written new unit tests. See our Wiki for conventions used in this package. Incomplete
Creation/updated relevant roxygen headers and examples. See our Wiki for conventions used in this package. Incomplete
Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately Incomplete
Run pkgdown::build_site() and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page. Incomplete
Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers) Incomplete
The NEWS.md entry should go under the # xportr development version section. Don't worry about updating the version because it will be auto-updated using the vbump.yaml CI. Incomplete
Address any updates needed for vignettes and/or templates. Incomplete
Link the issue Development Panel so that it closes after successful merging. Incomplete
The developer is responsible for fixing merge conflicts not the Reviewer. Incomplete
Pat yourself on the back for a job well done! Much love to your accomplishment! Incomplete