Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add length check <=200 bytes #194

Merged
merged 7 commits into from
Dec 15, 2023

add across/where to import

6a74578
Select commit
Loading
Failed to load commit list.
Merged

add length check <=200 bytes #194

add across/where to import
6a74578
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2023-12-15 16:36:02 ago

0 / 14 tasks completed

14 tasks still to be completed

Details

Required Tasks

Task Status
The spirit of xportr is met in your Pull Request Incomplete
Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update) Incomplete
Summary of changes filled out in the above Changes Description. Can be removed or left blank if changes are minor/self-explanatory. Incomplete
Check that your Pull Request is targeting the devel branch, Pull Requests to main should use the Release Pull Request Template Incomplete
Code is formatted according to the tidyverse style guide. Use styler package and functions to style files accordingly. Incomplete
Updated relevant unit tests or have written new unit tests. See our Wiki for conventions used in this package. Incomplete
Creation/updated relevant roxygen headers and examples. See our Wiki for conventions used in this package. Incomplete
Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately Incomplete
Run pkgdown::build_site() and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page. Incomplete
Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers) Incomplete
Address any updates needed for vignettes and/or templates Incomplete
Link the issue Development Panel so that it closes after successful merging. Incomplete
Fix merge conflicts Incomplete
Pat yourself on the back for a job well done! Much love to your accomplishment! Incomplete
Metadata length Incomplete
Data length (maximum value length) Incomplete
Data length > metadata length: This will cause the truncation of the data. This case is handled by Haven. The length is the one from the data, and a message is given. Incomplete
Data length < metadata length: In that case, to reduce the file size, the FDA requests trimming the variable length. In this case, we could give a message so the user can update the metadata length. Incomplete
Metadata length is missing: For character variables, should we assign the data length or 200? In order to trim the variable, I suggest using the data length. Per define.xml specification, the --DTC variables should have the length missing in define.xml, so this scenario is probable. Incomplete
tidyverse/haven#746 Incomplete
#202 Incomplete
Can you add those 2 in R/xportr-package.R and re-generate the documents? (see diff at the end of the commit) Incomplete
Please use summarize instead of summarise as that is already imported 😅 Incomplete