-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend xportr_write
to accept metadata
and deprecate label
#185
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 581 588 +7
=========================================
+ Hits 581 588 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small doc comments but looks great
Co-authored-by: Eli Miller <[email protected]>
Co-authored-by: Eli Miller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I just have concerns on the documentation when we don't use xportr_metadata()
to set everything for the dataset label.
Not sure if I went overboard by exporting the |
…el_from_metadata # Conflicts: # DESCRIPTION # NEWS.md
Changes Description
The
xportr_write()
function follows the same design as the rest of thexportr_*
functions by asking for themetadata
argument. Thus we're deprecating thelabel
argument from this function.Setting the dataset label can be done either using
xportr_write()
orxportr_df_label()
Here is some code to test the
xportr_write()
Task List
devel
branch, Pull Requests tomain
should use the Release Pull Request Templatestyler
package and functions to style files accordingly.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelypkgdown::build_site()
and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page.