Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues simplification #100

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Fix issues simplification #100

merged 7 commits into from
Apr 11, 2024

Conversation

statasaurus
Copy link
Collaborator

The issues were two fold,

  • the code lists were just appearing as null case it was trying to match the code list type to the variable type
  • non-unique names for the derivation_id of predecessor variables when read in via the spec_to_metacore

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 86.65%. Comparing base (94a2519) to head (7682693).

❗ Current head 7682693 differs from pull request most recent head e21eb69. Consider uploading reports for the commit e21eb69 to get more accurate results

Files Patch % Lines
R/spec_builder.R 76.47% 4 Missing ⚠️
R/metacore.R 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #100      +/-   ##
==========================================
- Coverage   86.75%   86.65%   -0.10%     
==========================================
  Files           7        7              
  Lines        1004     1019      +15     
==========================================
+ Hits          871      883      +12     
- Misses        133      136       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mstackhouse mstackhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here add some new lines that aren't covered by unit tests, and it looks like it would be beneficial to have those lines covered because it's a new consideration and scenario. @statasaurus can you add tests before we merge?

I realised I wasn't ever pulling the information from the comment
@statasaurus statasaurus merged commit da47c6a into dev Apr 11, 2024
5 checks passed
@statasaurus statasaurus deleted the fix-simplification branch April 11, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants