Skip to content

Commit

Permalink
Correction to support Julia 1.10 and putting back the tests with the …
Browse files Browse the repository at this point in the history
…latest Julia version (#1125)
  • Loading branch information
rrsadykov authored Jan 31, 2024
1 parent d1064d8 commit ce28df4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,8 @@ jobs:
fail-fast: false
matrix:
version:
- '1.6.7' # minimum Julia version that your package supports. (new LTS)
- '1.8.5' # "work" version for Atoptima deployements
#- '1' # Leave this line unchanged. '1' will automatically expand to the latest stable 1.x release of Julia.
# for the moment, latest stable version 1.10 errors, we need to repair it
- '1.6' # minimum Julia version that your package supports. (new LTS)
- '1' # Leave this line unchanged. '1' will automatically expand to the latest stable 1.x release of Julia.
os:
- ubuntu-latest
arch:
Expand Down
2 changes: 1 addition & 1 deletion src/MathProg/vcids.jl
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ Base.promote_rule(::Type{<:Id}, ::Type{<:Id}) = Int
# existing ids.
# As we want that all operations on ids results on operations on the uid,
# we redefine the promotion mechanism for Ids so that operations on Ids return integer:
Base.promote_type(::Type{I}, ::Type{I}) where {I<:Id} = Int32
Base.promote_type(::Type{I}, ::Type{I}) where {I<:Id} = Int

Base.convert(::Type{Int}, id::I) where {I<:Id} = Int(id.uid)
Base.convert(::Type{Int32}, id::I) where {I<:Id} = id.uid
Expand Down

0 comments on commit ce28df4

Please sign in to comment.