Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Fix: Libs: KiCad: Fileformat: Permit version key in fp-lib-table file to be absent #99

Merged

Conversation

sam-mellor
Copy link
Contributor

@sam-mellor sam-mellor commented Oct 23, 2024

Fix: Libs: KiCad: Fileformat: Permit version key in fp-lib-table file to be absent

Description

Expected file contents:

(fp_lib_table
  (version 7)
  (lib ...)
)

On my machine:

(fp_lib_table
  (lib ...)
)

Resulting in DecodeError: Failed to decode fp_lib_table

This allows for decoding in both cases.

TODO: retain the version number check, when present

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

@iopapamanoglou iopapamanoglou merged commit eaead9d into main Oct 24, 2024
2 checks passed
@iopapamanoglou iopapamanoglou deleted the bugfix/fp-lib-table_parsing_missing_version_key branch October 24, 2024 08:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants