Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Picker: Add API picker #92

Merged
merged 31 commits into from
Oct 26, 2024
Merged

Picker: Add API picker #92

merged 31 commits into from
Oct 26, 2024

Conversation

sam-mellor
Copy link
Contributor

@sam-mellor sam-mellor commented Oct 17, 2024

Picker: Add API Picker

Description

Adds API picker lib to source parts from remote backend.

Usage: set FBRK_PICKER=api

TODO:

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

@sam-mellor sam-mellor added the enhancement New feature or request label Oct 17, 2024
@sam-mellor sam-mellor marked this pull request as draft October 17, 2024 01:39
@sam-mellor sam-mellor force-pushed the feature/api_picker branch 2 times, most recently from 5345d36 to 91baf5a Compare October 21, 2024 22:56
Copy link
Contributor

@iopapamanoglou iopapamanoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks already pretty good!

  • Have a look at my minor changes
  • A bit careful with when raising PickErrors vs other Exceptions: PickErrors are caught so don't raise them for static programming errors
  • Turn on your type checking in cursor
    image
  • API should be a singleton, conditional init creates weird behavior
  • (nearly) all test cases pass, but the examples don't work with the api picker (no parts found for resistor)

@iopapamanoglou
Copy link
Contributor

Looks great! Only fixing some bugs left.
Some examples still seem to not work properly.
Nearly there 😁

@sam-mellor sam-mellor changed the title WIP: Picker: Add API picker Picker: Add API picker Oct 24, 2024
@sam-mellor sam-mellor marked this pull request as ready for review October 24, 2024 23:09
Copy link
Contributor

@iopapamanoglou iopapamanoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@iopapamanoglou iopapamanoglou merged commit 8d12b33 into main Oct 26, 2024
2 checks passed
@iopapamanoglou iopapamanoglou deleted the feature/api_picker branch October 26, 2024 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants