Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

WIP: Core: Param rework #87

Closed
wants to merge 80 commits into from
Closed

WIP: Core: Param rework #87

wants to merge 80 commits into from

Conversation

iopapamanoglou
Copy link
Contributor

Core: Param rework

Description

Fixes # (issue)

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

NoR8quoh1r and others added 30 commits October 8, 2024 13:28
@NoR8quoh1r
Core: Move current parameter implementation
4e151ba 
Move it to a folder, such that we can implement the new version in
the parameter namespace.
@NoR8quoh1r
Core: Add minimal Range implementation for new params
048df64
@NoR8quoh1r
Core: Add mostly empty new Parameter class
b5f0a8b
@iopapamanoglou
Sets.py; Delte old params; Tests
cb3a25f
@iopapamanoglou
Add parameter constructor
c0f0418
@NoR8quoh1r
Core: Add some arithmetic expressions
5675489
@iopapamanoglou
Namespace
066bad8
@iopapamanoglou
lambda warnings
8da05dd
@NoR8quoh1r
Core: Add more arithmetic expressions
0bd8b29
@iopapamanoglou
functions for ops
0e5209d
@iopapamanoglou
L sets
a869db8
@NoR8quoh1r
Core: Make expression node and add check
4566a02
@iopapamanoglou
WIP: Library refactor
10c3e67
@NoR8quoh1r
Core:
b091b22 
rename unit to units
give sets units
logic & setic expressions
@iopapamanoglou
fix range from_cente
df73c8a
@iopapamanoglou
unit => units
2792ca3
@iopapamanoglou
Replace merge with {subset, superset, alias_is} half Lib
52126b2
@iopapamanoglou @NoR8quoh1r
Replace merge with {subset, superset, alias_is} half Lib
988bf1c
@iopapamanoglou
Fix F.Range -> L.Range
ac1b98b
@iopapamanoglou
Fix ParameterOperatable param types; Run ruff
3d0fafc
@NoR8quoh1r
Librar: Remove F.Constant in function signatures
a74bd73
@NoR8quoh1r
Library: Take ParameterOperatable in function signatures
6a6975d
@iopapamanoglou
remove singles
76efaab
@iopapamanoglou
remove last param operands
66b5a71
@iopapamanoglou
ruff
d247aa4
@NoR8quoh1r
Core: Parameter: Add some checks to predicates
4a3629a
@NoR8quoh1r
Params: Rework rated_* slightly
0707414 
mostly renaming
@iopapamanoglou
Remove merge from non lib
414d305
@iopapamanoglou
Remove esphome Param stuff
59965dd
@iopapamanoglou
add abstract decorator
41afca7
@iopapamanoglou iopapamanoglou mentioned this pull request Oct 29, 2024
Open
5 tasks
@iopapamanoglou iopapamanoglou mentioned this pull request Nov 13, 2024
Closed
11 tasks
mawildoer
mawildoer reviewed Nov 13, 2024
View reviewed changes
src/faebryk/core/parameter.py
def obviously_eq(self, other: "ParameterOperatable.All") -> bool:
if self == other:
return True
if other in self._is_constrains():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be bi-directional? That is, self in other._is_constrains?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mawildoer mawildoer mawildoer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iopapamanoglou @mawildoer @NoR8quoh1r