This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Core: KiCAD Sch Fileformat #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mawildoer
force-pushed
the
mawildoer/kicad-schematic-exporter-2
branch
from
51f3392 to
bd03830
Compare
mawildoer
commented
Sep 13, 2024
| @@ -123,7 +124,8 @@ def connect(self, other: Self, linkcls=None) -> Self: | |||
| self.G.add_edge(self, other, link=link) | |||
|
|
|||
| if logger.isEnabledFor(logging.DEBUG): | |||
| logger.debug(f"GIF connection: {link}") | |||
| with exceptions_to_log(): | |||
There was a problem hiding this comment.
I had to add this because with logging at debug it failed to import this file
The stringification of some edge in the graph was hitting a NotNone assertion
This is the best solution IMO though because we shouldn't be killing the program with debug exceptions that might just be caused by import-time execution
There was a problem hiding this comment.
Thanks for clarifying!
iopapamanoglou
approved these changes
Sep 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add KiCAD schematic fileformat support
Fixes # (issue)
Checklist
Please read and execute the following:
Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct: