Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

CI: explicity execute pre-commit in CI on PRs #47

Merged
merged 2 commits into from
Sep 9, 2024
Merged

CI: explicity execute pre-commit in CI on PRs #47

merged 2 commits into from
Sep 9, 2024

Conversation

mawildoer
Copy link
Contributor

@mawildoer mawildoer commented Sep 9, 2024 •
edited
Loading

Description

Explicitly run pre-commit in CI on every task.
This means someone not having pre-commit goes from being bad for us to just bad for them. Ideal 👌

Fixes # (issue)

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

@mawildoer mawildoer marked this pull request as ready for review September 9, 2024 19:49
@mawildoer mawildoer self-assigned this Sep 9, 2024
@mawildoer
Copy link
Contributor Author

Ready to merge! @iopapamanoglou

iopapamanoglou
iopapamanoglou approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@iopapamanoglou iopapamanoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition thanks!

@iopapamanoglou iopapamanoglou merged commit 5644350 into main Sep 9, 2024
2 checks passed
@iopapamanoglou iopapamanoglou deleted the mawildoer/pre-commit-in-ci branch September 9, 2024 19:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iopapamanoglou iopapamanoglou iopapamanoglou approved these changes

Assignees

@mawildoer mawildoer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mawildoer @iopapamanoglou