This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
KiCAD Schematic Exporter MVP #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-schematic-exporter-12
mawildoer
force-pushed
the
mawildoer/kicad-schematic-exporter-12
branch
from
6837164 to
0f4d2fd
Compare
mawildoer
force-pushed
the
mawildoer/kicad-schematic-exporter-12
branch
from
cb927d6 to
d44e838
Compare
mawildoer
commented
Nov 6, 2024
src/faebryk/core/trait.py
Outdated
| @@ -110,6 +110,12 @@ def _handle_added_to_parent(self): | |||
| def on_obj_set(self): ... | |||
|
|
|||
| def handle_duplicate(self, other: "TraitImpl", node: Node) -> bool: | |||
| """ | |||
There was a problem hiding this comment.
@IoannisP-ITENG I'm not sure this is 100% accurate. It'd be handy to know what the return means?
| @@ -0,0 +1,64 @@ | |||
| # This file is part of the faebryk project | |||
There was a problem hiding this comment.
@IoannisP-ITENG I've got more hints to add to this, and imagine it'll grow with time.
What do you think of this pattern?
| @@ -27,6 +26,12 @@ | |||
|
|
|||
|
|
|||
| def uuid_field(): | |||
| def gen_uuid(): | |||
There was a problem hiding this comment.
Boy... this got to be a big mess. One of the tests had a circular import, which this managed to break.
test/common/libs/test.kicad_sym
Outdated
There was a problem hiding this comment.
Moved this and updated the tests because it's a usually part of the lib dir, so this format matches reality better
|
Superseded by atopile/atopile#537 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the base of something that needs on-going work to produce schematics EEs will be happy with.
Fixes # (issue)
Checklist
Please read and execute the following:
Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct: