Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Bugfix: Picker: Attach params on ID or MFR pick #109

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

iopapamanoglou
Copy link
Contributor

Bugfix: Picker: Attach params on ID or MFR pick

Description

When picking a part by LCSC ID or MFR attach the parsed parameters to the module.

Fixes # (issue)

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

@iopapamanoglou iopapamanoglou merged commit 80c5fde into main Oct 29, 2024
6 checks passed
@iopapamanoglou iopapamanoglou deleted the bugfix/attach_params_on_id_pick branch October 29, 2024 10:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant