This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Core: Fix pytest rebuilder and improve editable installation detection #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mawildoer
commented
Oct 28, 2024
src/faebryk/core/cpp/__init__.py
Outdated
| from typing import Callable | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| # Check if installed as editable | ||
| def is_editable_install(): | ||
| site_packages = site.getsitepackages() | ||
| return not any((pathlib.Path(sp) / "faebryk").exists() for sp in site_packages) | ||
| distro = Distribution.from_name(__name__.split(".")[0]) |
There was a problem hiding this comment.
Hit an issue and apparently this is a more robust way to detect editable installation: https://stackoverflow.com/questions/43348746/how-to-detect-if-module-is-installed-in-editable-mode
src/faebryk/core/cpp/__init__.py
Outdated
| @@ -43,7 +48,7 @@ def _do(*args, **kwargs): | |||
| "cmake not found, needed for compiling c++ code in editable mode" | |||
| ) | |||
|
|
|||
| pybind11_dir = _do(["python", "-m", "pybind11", "--cmakedir"]).strip() | |||
| pybind11_dir = _do([sys.executable, "-m", "pybind11", "--cmakedir"]).strip() | |||
There was a problem hiding this comment.
This fixes a venv issues I had causing pytest failures
mawildoer
force-pushed
the
mawildoer/osx-build-arch
branch
4 times, most recently
from
1777d88 to
c9a921c
Compare
mawildoer
force-pushed
the
mawildoer/osx-build-arch
branch
from
c9a921c to
4d88d57
Compare
iopapamanoglou
approved these changes
Oct 29, 2024
mawildoer
commented
Oct 29, 2024
|
|
||
| def test_add(): | ||
| from faebryk.core.cpp import add |
There was a problem hiding this comment.
Importing here yields vastly better errors on import failures. It's common/recommended with pytest anyway
| @@ -1082,3 +1084,54 @@ def setdefault(self, key: T, default: U) -> U: | |||
| except KeyError: | |||
| self[key] = default | |||
| return default | |||
|
|
|||
|
|
|||
| def run_live( | |||
There was a problem hiding this comment.
Had a little help from our dear friend Claude to go a bit bananas here. Was very helpful for debugging. I'd dump the streams just afterwards, but it's quite hard to tell in what order something was sent to stdout or stderr like that
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Checklist
Please read and execute the following:
Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct: