Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Core: Build wheels for the appropriate architecture on OSx devices #107

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

mawildoer
Copy link
Contributor

@mawildoer mawildoer commented Oct 28, 2024

On OSx, the architecture mightn't be reliably auto-detected because Macs try to abstract some of the hard stuff.

This PR explicitly detects and adds a build flag for the right architecture on OSx.
Additionally, it adds logging of the stderr stream on failures for debugging

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

@mawildoer mawildoer force-pushed the mawildoer/osx-build-arch branch from 8d5995a to 1b37e26 Compare October 28, 2024 20:09
Copy link
Contributor

@iopapamanoglou iopapamanoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@mawildoer mawildoer merged commit d28810e into main Oct 28, 2024
6 checks passed
@mawildoer mawildoer deleted the mawildoer/osx-build-arch branch October 28, 2024 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants