Remove _on_connect

src/faebryk/core/cpp/src/main.cpp

@@ -66,7 +66,8 @@ PYMOD(m) {
     m.def("set_leak_warnings", &nb::set_leak_warnings, "value"_a);
     m.def("print_obj", &print_obj, "obj"_a);
 
-    m.def("find_paths", &find_paths, "src"_a, "dst"_a);
+    // TODO why this rv_pol needed
+    m.def("find_paths", &find_paths, "src"_a, "dst"_a, nb::rv_policy::reference);
 
     // Graph
     using GI = GraphInterface;

src/faebryk/core/module.py

@@ -3,7 +3,7 @@
 import logging
 from typing import TYPE_CHECKING, Callable, Iterable
 
-from faebryk.core.moduleinterface import GraphInterfaceModuleSibling
+from faebryk.core.cpp import GraphInterfaceModuleSibling
 from faebryk.core.node import Node, NodeException, f_field
 from faebryk.core.trait import Trait
 from faebryk.libs.util import cast_assert, unique_ref

src/faebryk/core/moduleinterface.py

@@ -6,7 +6,6 @@
     cast,
 )
 
-from deprecated import deprecated
 from typing_extensions import Self
 
 from faebryk.core.cpp import (
@@ -65,11 +64,6 @@ def __init__(self):
 
     def __preinit__(self) -> None: ...
 
-    @deprecated("Isn't called anymore. Use parameter.is_dynamic")
-    def _on_connect(self, other: "ModuleInterface"):
-        """override to handle custom connection logic"""
-        ...
-
     def connect(self: Self, *other: Self, linkcls=None) -> Self:
         if not {type(o) for o in other}.issubset({type(self)}):
             raise NodeException(
@@ -142,13 +136,7 @@ def specialize[T: ModuleInterface](self, special: T) -> T:
     #    return None
 
     def __init_subclass__(cls, *, init: bool = True) -> None:
-        if cls._on_connect is not ModuleInterface._on_connect:
-            logger.warning(
-                f"ModuleInterface subclass {cls} has custom _on_connect method"
-            )
-            # TODO raise
-            # raise TypeError(
-            #    "Overriding _on_connect is deprecated"
-            # )
+        if hasattr(cls, "_on_connect"):
+            raise TypeError("Overriding _on_connect is deprecated")
 
         return super().__init_subclass__(init=init)