404 -> PickError

src/faebryk/libs/picker/api/api.py

@@ -32,6 +32,17 @@ class ApiError(Exception): ...
 class ApiNotConfiguredError(ApiError): ...
 
 
+class ApiHTTPError(ApiError):
+    def __init__(self, error: requests.exceptions.HTTPError):
+        super().__init__()
+        self.response = error.response
+
+    def __str__(self) -> str:
+        status_code = self.response.status_code
+        detail = self.response.json()["detail"]
+        return f"{super().__str__()}: {status_code} {detail}"
+
+
 def check_compatible_parameters(
     module: Module, component: Component, mapping: list[MappingParameterDB]
 ) -> bool:
@@ -177,7 +188,7 @@ def _get(self, url: str, timeout: float = 10) -> requests.Response:
             response = self._client.get(f"{self.config.api_url}{url}", timeout=timeout)
             response.raise_for_status()
         except requests.exceptions.HTTPError as e:
-            raise ApiError(f"Failed to fetch {url}: {e}") from e
+            raise ApiHTTPError(e) from e
 
         return response
 
@@ -190,7 +201,7 @@ def _post(
             )
             response.raise_for_status()
         except requests.exceptions.HTTPError as e:
-            raise ApiError(f"Failed to fetch {url}: {e}") from e
+            raise ApiHTTPError(e) from e
 
         return response
 

src/faebryk/libs/picker/api/pickers.py

@@ -4,7 +4,7 @@
 import faebryk.library._F as F
 import faebryk.libs.picker.api.picker_lib as picker_lib
 from faebryk.core.module import Module
-from faebryk.libs.picker.api.api import ApiNotConfiguredError
+from faebryk.libs.picker.api.api import ApiHTTPError
 from faebryk.libs.picker.common import StaticPartPicker
 from faebryk.libs.picker.jlcpcb.jlcpcb import Component
 from faebryk.libs.picker.picker import PickError
@@ -14,11 +14,11 @@ class ApiPicker(F.has_multi_picker.FunctionPicker):
     def pick(self, module: Module):
         try:
             super().pick(module)
-        except ApiNotConfiguredError:
-            raise
-        # TODO do we actually ever want to catch this?
-        # except ApiError as e:
-        #    raise PickError(e.args[0], module) from e
+        except ApiHTTPError as e:
+            if e.response.status_code == 404:
+                raise PickError(str(e), module) from e
+            else:
+                raise
 
 
 class StaticApiPartPicker(StaticPartPicker):