Implement field setup

new_holders_flat.py

@@ -1,15 +1,13 @@
 from dataclasses import field
 
+import typer
+
 from faebryk.core.module import Module
 from faebryk.core.node import d_field, if_list, rt_field
-from faebryk.core.util import as_unit
 from faebryk.library.can_bridge_defined import can_bridge_defined
 from faebryk.library.Electrical import Electrical
 from faebryk.library.has_designator_prefix import has_designator_prefix
 from faebryk.library.has_designator_prefix_defined import has_designator_prefix_defined
-from faebryk.library.has_simple_value_representation_based_on_param import (
-    has_simple_value_representation_based_on_param,
-)
 from faebryk.library.TBD import TBD
 from faebryk.libs.units import Quantity
 from faebryk.libs.util import times
@@ -27,6 +25,8 @@ class Diode2(Module):
     anode: Electrical
     cathode: Electrical
 
+    XXXXX: Electrical = d_field(Electrical)
+
     # static trait
     designator_prefix: has_designator_prefix = d_field(
         lambda: has_designator_prefix_defined("D")
@@ -37,43 +37,55 @@ class Diode2(Module):
     def bridge(self):
         return can_bridge_defined(self.anode, self.cathode)
 
-    def __finit__(self):
-        print("Called Diode __finit__")
+    def __preinit__(self):
+        print("Called Diode __preinit__")
 
         # anonymous dynamic trait
-        self.add(
-            has_simple_value_representation_based_on_param(
-                self.forward_voltage,
-                lambda p: as_unit(p, "V"),
-            )  # type: ignore
-        )
+        # self.add(
+        #     has_simple_value_representation_based_on_param(
+        #         self.forward_voltage,
+        #         lambda p: as_unit(p, "V"),
+        #     )  # type: ignore
+        # )
 
 
 class LED2(Diode2):
     color: TBD[float]
 
-    def __finit__(self):
-        print("Called LED __finit__")
+    def __preinit__(self):
+        print("Called LED __preinit__")
 
 
 class LED2_NOINT(LED2, init=False):
-    def __finit__(self):
-        print("Called LED_NOINT __finit__")
+    def __preinit__(self):
+        print("Called LED_NOINT __preinit__")
 
 
 class LED2_WITHEXTRAT_IFS(LED2):
     extra: list[Electrical] = field(default_factory=lambda: times(2, Electrical))
     extra2: list[Electrical] = if_list(Electrical, 2)
 
-    def __finit__(self):
-        print("Called LED_WITHEXTRAT_IFS __finit__")
+    @rt_field
+    def bridge(self):
+        return can_bridge_defined(self.extra2[0], self.extra2[1])
+
+    def __preinit__(self):
+        print("Called LED_WITHEXTRAT_IFS __preinit__")
+
+
+def main():
+    print("Diode init ----")
+    _D = Diode2()
+    print("LED init ----")
+    _L = LED2()
+    print("LEDNOINIT init ----")
+    L2 = LED2_NOINT()
+    print("LEDEXTRA init ----")
+    L3 = LED2_WITHEXTRAT_IFS()
+
+    L3.cathode.connect(L2.cathode)
+
+    assert L3.cathode.is_connected_to(L2.cathode)
 
 
-print("Diode init ----")
-D = Diode2()
-print("LED init ----")
-L = LED2()
-print("LEDNOINIT init ----")
-L2 = LED2_NOINT()
-print("LEDEXTRA init ----")
-L3 = LED2_WITHEXTRAT_IFS()
+typer.run(main)

src/faebryk/core/link.py

@@ -50,8 +50,9 @@ def get_connections(self) -> list["GraphInterface"]:
 class LinkParent(Link):
     def __init__(self, interfaces: list["GraphInterface"]) -> None:
         super().__init__()
+        from faebryk.core.graphinterface import GraphInterfaceHierarchical
 
-        assert all([isinstance(i, "GraphInterfaceHierarchical") for i in interfaces])
+        assert all([isinstance(i, GraphInterfaceHierarchical) for i in interfaces])
         # TODO rethink invariant
         assert len(interfaces) == 2
         assert len([i for i in interfaces if i.is_parent]) == 1  # type: ignore

src/faebryk/core/moduleinterface.py

@@ -21,6 +21,7 @@
     _TLinkDirectShallow,
 )
 from faebryk.core.node import Node
+from faebryk.core.trait import Trait
 from faebryk.libs.util import print_stack
 
 logger = logging.getLogger(__name__)
@@ -90,6 +91,8 @@ class GraphInterfaceModuleConnection(GraphInterface): ...
 
 
 class ModuleInterface(Node):
+    class TraitT(Trait["ModuleInterface"]): ...
+
     specializes: GraphInterface
     specialized: GraphInterface
     connected: GraphInterfaceModuleConnection