Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Commit

Permalink
add comments
Browse files Browse the repository at this point in the history
  • Loading branch information
iopapamanoglou committed Nov 15, 2024
1 parent 13a8651 commit 16d83a4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 21 deletions.
24 changes: 3 additions & 21 deletions src/faebryk/core/defaultsolver.py
Original file line number Diff line number Diff line change
Expand Up @@ -851,28 +851,10 @@ class DefaultSolver(Solver):
def phase_one_no_guess_solving(self, g: Graph) -> None:
logger.info(f"Phase 1 Solving: No guesses {'-' * 80}")

# TODO move into comment here
# strategies
# https://miro.com/app/board/uXjVLV3O2BQ=/
# compress expressions inside alias classes
# x / y => x / x
# associativity
# (x + a) + b => x + a + b [for +,*]
# compress expressions that are using literals
# x + 1 + 5 => x + 6
# x + 0 => x
# x * 1 => x
# x * 0 => 0
# x / 1 => x
# compress calculatable expressions
# x / x => 1
# x + x => 2*x
# x - x => 0
# x * x => x^2
# k*x + l*x => (k+l)*x
# sqrt(x^2) => abs(x)
# sqrt(x) * sqrt(x) => x

# as long as progress iterate
# https://www.notion.so/
# Phase1-136836dcad9480cbb037defe359934ee?pvs=4#136836dcad94807d93bccb14598e1ef0

logger.info("Phase 0 Solving: normalize graph")
repr_map = normalize_graph(g)
Expand Down
1 change: 1 addition & 0 deletions test/libs/picker/test_pickers.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ def test_pick_module(case: ComponentTestCase, picker: PickerTestCase):
for param in params:
# Test if all params are aliased to Literal
param.get_literal()
# FIXME this is not correct, since some picks won't have all params picked
# TODO check that part params are equal (alias_is) to module params

# Check footprint
Expand Down

0 comments on commit 16d83a4

Please sign in to comment.