[POC] Unmount ref

.circleci/config.yml

@@ -151,7 +151,7 @@ jobs:
           react-version: << parameters.react-version >>
       - run:
           name: Run tests on JSDOM
-          command: pnpm test:jsdom --coverage
+          command: pnpm test:jsdom:coverage
       - run:
           name: Check if coverage report is generated
           command: |
@@ -290,7 +290,7 @@ jobs:
           browsers: true
       - run:
           name: Run tests on headless Chromium
-          command: pnpm test:chromium --coverage
+          command: pnpm test:chromium:coverage
       - run:
           name: Check if coverage report is generated
           command: |
@@ -304,36 +304,6 @@ jobs:
             curl -Os https://uploader.codecov.io/latest/linux/codecov
             chmod +x codecov
             ./codecov -t ${CODECOV_TOKEN} -Z -F "$REACT_VERSION-browser"
-      - store_artifacts:
-          # hardcoded in karma-webpack
-          path: /tmp/_karma_webpack_
-          destination: artifact-file
-  test_profile:
-    <<: *default-job
-    docker:
-      - image: mcr.microsoft.com/playwright:v1.49.1-noble
-    steps:
-      - checkout
-      - install_js:
-          react-version: << parameters.react-version >>
-          browsers: true
-      - run:
-          name: Tests real browsers
-          # Run a couple of times for a better sample.
-          # TODO: hack something together where we can compile once and run multiple times e.g. by abusing watchmode.
-          command: |
-            # Running on chrome only since actual times are innaccurate anyway
-            # The other reason is that browserstack allows little concurrency so it's likely that we're starving other runs.
-            pnpm test:karma:profile --browsers chrome,chromeHeadless
-            pnpm test:karma:profile --browsers chrome,chromeHeadless
-            pnpm test:karma:profile --browsers chrome,chromeHeadless
-            pnpm test:karma:profile --browsers chrome,chromeHeadless
-            pnpm test:karma:profile --browsers chrome,chromeHeadless
-      # Persist reports for inspection in https://mui-dashboard.netlify.app/
-      - store_artifacts:
-          # see karma.conf.profile.js reactProfilerReporter.outputDir
-          path: tmp/react-profiler-report/karma
-          destination: react-profiler-report/karma
   test_regressions:
     <<: *default-job
     docker:
@@ -365,9 +335,6 @@ jobs:
     steps:
       - checkout
       - install_js
-      - run:
-          name: Run danger on PRs
-          command: pnpm danger ci --fail-on-errors
       # TODO test bundle size https://github.com/mui/base-ui/issues/201
   test_package:
     <<: *default-job
@@ -430,12 +397,6 @@ workflows:
           <<: *default-context
           requires:
             - checkout
-  profile:
-    when:
-      equal: [profile, << pipeline.parameters.workflow >>]
-    jobs:
-      - test_profile:
-          <<: *default-context
   react-17:
     triggers:
       - schedule:

.eslintignore

@@ -1,5 +1,4 @@
 .git
-.nyc_output
 /coverage
 /docs/.next
 /docs/export

.eslintrc.js

@@ -53,8 +53,38 @@ module.exports = {
   },
   overrides: [
     ...baseline.overrides.filter(
-      (ruleSet) => !ruleSet.rules.hasOwnProperty('filenames/match-exported'),
+      (ruleSet) =>
+        !ruleSet.rules.hasOwnProperty('filenames/match-exported') &&
+        !ruleSet.extends?.includes('plugin:mocha/recommended'),
     ),
+    {
+      files: [
+        // matching the pattern of the test runner
+        '*.test.?(c|m)[jt]s?(x)',
+      ],
+      rules: {
+        // disable eslint-plugin-jsx-a11y
+        // tests are not driven by assistive technology
+        // add `jsx-a11y` rules once you encounter them in tests
+        'jsx-a11y/click-events-have-key-events': 'off',
+        'jsx-a11y/control-has-associated-label': 'off',
+        'jsx-a11y/iframe-has-title': 'off',
+        'jsx-a11y/label-has-associated-control': 'off',
+        'jsx-a11y/mouse-events-have-key-events': 'off',
+        'jsx-a11y/no-noninteractive-tabindex': 'off',
+        'jsx-a11y/no-static-element-interactions': 'off',
+        'jsx-a11y/tabindex-no-positive': 'off',
+
+        // In tests this is generally intended.
+        'react/button-has-type': 'off',
+        // They are accessed to test custom validator implementation with PropTypes.checkPropTypes
+        'react/forbid-foreign-prop-types': 'off',
+        // components that are defined in test are isolated enough
+        // that they don't need type-checking
+        'react/prop-types': 'off',
+        'react/no-unused-prop-types': 'off',
+      },
+    },
     {
       files: ['docs/src/app/(private)/experiments/**/*{.tsx,.js}'],
       rules: {
@@ -87,5 +117,12 @@ module.exports = {
         '@typescript-eslint/no-use-before-define': 'off',
       },
     },
+    {
+      files: ['test/**/*{.ts,.tsx}'],
+      rules: {
+        'react/prop-types': 'off',
+        'guard-for-in': 'off',
+      },
+    },
   ],
 };

.github/ISSUE_TEMPLATE/3.get-help.md

@@ -7,4 +7,4 @@
 
 ## Ask a question
 
-Before opening an issue, please consider starting a [GitHub Discussion](https://github.com/mui/base-ui/discussions) or asking the community for help in our [Discord](https://discord.com/channels/1287292451308048406/1287292451308048409).
+Before opening an issue, please consider starting a [GitHub Discussion](https://github.com/mui/base-ui/discussions) or asking the community for help in our [Discord](https://base-ui.com/r/discord).

.github/workflows/codeql.yml

@@ -19,7 +19,7 @@ jobs:
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@f09c1c0a94de965c15400f5634aa42fac8fb8f88 # v3.27.5
+        uses: github/codeql-action/init@48ab28a6f5dbc2a99bf1e0131198dd8f1df78169 # v3.28.0
         with:
           languages: typescript
           config-file: ./.github/codeql/codeql-config.yml
@@ -30,4 +30,4 @@ jobs:
           # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
           # queries: security-extended,security-and-quality
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@f09c1c0a94de965c15400f5634aa42fac8fb8f88 # v3.27.5
+        uses: github/codeql-action/analyze@48ab28a6f5dbc2a99bf1e0131198dd8f1df78169 # v3.28.0

.github/workflows/scorecards.yml

@@ -43,6 +43,6 @@ jobs:
 
       # Upload the results to GitHub's code scanning dashboard.
       - name: Upload to code-scanning
-        uses: github/codeql-action/upload-sarif@f09c1c0a94de965c15400f5634aa42fac8fb8f88 # v3.27.5
+        uses: github/codeql-action/upload-sarif@48ab28a6f5dbc2a99bf1e0131198dd8f1df78169 # v3.28.0
         with:
           sarif_file: results.sarif

.gitignore

@@ -10,7 +10,6 @@
 *.log
 *.tsbuildinfo
 /.eslintcache
-/.nyc_output
 /coverage
 /docs/.env.local
 /docs/.next

CHANGELOG.md

@@ -1,5 +1,124 @@
 # Versions
 
+## v1.0.0-alpha.5
+
+_Jan 10, 2025_
+
+### AlertDialog
+
+- **Breaking change:** Require `Portal` part.
+  The AlertDialog must explicitly include the Portal part wrapping the Popup.
+  The `keepMounted` prop was removed from the Popup.
+  It's only present on the Portal part.
+  [#1222](https://github.com/mui/base-ui/pull/1222) @atomiks
+- Don't call `onNestedDialogOpen` when unmounting a closed nested dialog [#1280](https://github.com/mui/base-ui/pull/1280) @mj12albert
+- Fix the nesting of different dialogs [#1167](https://github.com/mui/base-ui/pull/1167) @mnajdova
+- Remove `useFloating` call from the Popup [#1300](https://github.com/mui/base-ui/pull/1300) @michaldudak
+- Set `pointer-events` on `InternalBackdrop` based on `open` state [#1221](https://github.com/mui/base-ui/pull/1221) @atomiks
+- Use internal backdrop for pointer modality [#1161](https://github.com/mui/base-ui/pull/1161) @atomiks
+
+### Dialog
+
+- **Breaking change:** Require `Portal` part.
+  The Dialog must explicitly include the Portal part wrapping the Popup.
+  The `keepMounted` prop was removed from the Popup.
+  It's only present on the Portal part.
+  [#1222](https://github.com/mui/base-ui/pull/1222) @atomiks
+- Don't call `onNestedDialogOpen` when unmounting a closed nested dialog [#1280](https://github.com/mui/base-ui/pull/1280) @mj12albert
+- Fix the nesting of different dialogs [#1167](https://github.com/mui/base-ui/pull/1167) @mnajdova
+- Remove `useFloating` call from the Popup [#1300](https://github.com/mui/base-ui/pull/1300) @michaldudak
+- Set `pointer-events` on `InternalBackdrop` based on `open` state [#1221](https://github.com/mui/base-ui/pull/1221) @atomiks
+- Use internal backdrop for pointer modality [#1161](https://github.com/mui/base-ui/pull/1161) @atomiks
+
+### Menu
+
+- **Breaking change:** Require `Portal` part.
+  The Menu must explicitly include the Portal part wrapping the Positioner.
+  The `keepMounted` prop was removed from the Positioner.
+  It's only present on the Portal part.
+  [#1222](https://github.com/mui/base-ui/pull/1222) @atomiks
+- Apply `aria-hidden` to `Arrow` parts [#1196](https://github.com/mui/base-ui/pull/1196) @atomiks
+- Fix `focusableWhenDisabled` components [#1313](https://github.com/mui/base-ui/pull/1313) @mj12albert
+- Fix `openOnHover` issues [#1191](https://github.com/mui/base-ui/pull/1191) @atomiks
+- Fix closing the menu when clicking on checkboxitem/radioitem [#1301](https://github.com/mui/base-ui/pull/1301) @michaldudak
+- Fix Enter key preventDefault when rendering links [#1251](https://github.com/mui/base-ui/pull/1251) @mj12albert
+- Handle pseudo-element bounds in mouseup detection [#1250](https://github.com/mui/base-ui/pull/1250) @atomiks
+- Set `pointer-events` on `InternalBackdrop` based on `open` state [#1221](https://github.com/mui/base-ui/pull/1221) @atomiks
+- Use internal backdrop for pointer modality [#1161](https://github.com/mui/base-ui/pull/1161) @atomiks
+
+### NumberField
+
+- Correctly handle quick touches [#1294](https://github.com/mui/base-ui/pull/1294) @atomiks
+
+### Popover
+
+- **Breaking change:** Require `Portal` part.
+  The Popover must explicitly include the Portal part wrapping the Positioner.
+  The `keepMounted` prop was removed from the Positioner.
+  It's only present on the Portal part.
+  [#1222](https://github.com/mui/base-ui/pull/1222) @atomiks
+- Apply `aria-hidden` to `Arrow` parts [#1196](https://github.com/mui/base-ui/pull/1196) @atomiks
+- Fix PopoverTrigger and TooltipTrigger prop types [#1209](https://github.com/mui/base-ui/pull/1209) @mnajdova
+
+### PreviewCard
+
+- **Breaking change:** Require `Portal` part.
+  The PreviewCard must explicitly include the Portal part wrapping the Positioner.
+  The `keepMounted` prop was removed from the Positioner.
+  It's only present on the Portal part.
+  [#1222](https://github.com/mui/base-ui/pull/1222) @atomiks
+- Apply `aria-hidden` to `Arrow` parts [#1196](https://github.com/mui/base-ui/pull/1196) @atomiks
+- Use `FloatingPortalLite` [#1278](https://github.com/mui/base-ui/pull/1278) @atomiks
+
+### Progress
+
+- Set zero width when value is zero [#1204](https://github.com/mui/base-ui/pull/1204) @mj12albert
+
+### ScrollArea
+
+- Differentiate `x`/`y` orientation `data-scrolling` [#1188](https://github.com/mui/base-ui/pull/1188) @atomiks
+- Read `DirectionProvider` and use logical positioning CSS props [#1194](https://github.com/mui/base-ui/pull/1194) @mj12albert
+
+### Select
+
+- **Breaking change:** Require `Portal` part.
+  The Select must explicitly include the Portal part wrapping the Positioner.
+  The `keepMounted` prop was removed from the Positioner.
+  It's only present on the Portal part.
+  [#1222](https://github.com/mui/base-ui/pull/1222) @atomiks
+- Allow `id` to be passed to trigger [#1174](https://github.com/mui/base-ui/pull/1174) @atomiks
+- Fallback to standard positioning when pinch-zoomed in Safari [#1139](https://github.com/mui/base-ui/pull/1139) @atomiks
+- Fix `focusableWhenDisabled` components [#1313](https://github.com/mui/base-ui/pull/1313) @mj12albert
+- Fix highlight flash on Safari [#1233](https://github.com/mui/base-ui/pull/1233) @atomiks
+- Handle pseudo-element bounds in mouseup detection [#1250](https://github.com/mui/base-ui/pull/1250) @atomiks
+- Use internal backdrop for pointer modality [#1161](https://github.com/mui/base-ui/pull/1161) @atomiks
+
+### Separator
+
+- Support vertical orientation [#1304](https://github.com/mui/base-ui/pull/1304) @mj12albert
+
+### Slider
+
+- Ensure `onValueCommitted` is called with the same value as latest `onValueChange` [#1296](https://github.com/mui/base-ui/pull/1296) @mj12albert
+- Replace internal map with `Composite` metadata [#1082](https://github.com/mui/base-ui/pull/1082) @mj12albert
+- Set `position: relative` on range slider indicator [#1175](https://github.com/mui/base-ui/pull/1175) @mj12albert
+- Use un-rounded values to position thumbs [#1219](https://github.com/mui/base-ui/pull/1219) @mj12albert
+
+### Tabs
+
+- Expose width/height state in tabs indicator [#1288](https://github.com/mui/base-ui/pull/1288) @aarongarciah
+
+### Tooltip
+
+- **Breaking change:** Require `Portal` part.
+  The Tooltip must explicitly include the Portal part wrapping the Positioner.
+  The `keepMounted` prop was removed from the Positioner.
+  It's only present on the Portal part.
+  [#1222](https://github.com/mui/base-ui/pull/1222) @atomiks
+- Apply `aria-hidden` to `Arrow` parts [#1196](https://github.com/mui/base-ui/pull/1196) @atomiks
+- Fix PopoverTrigger and TooltipTrigger prop types [#1209](https://github.com/mui/base-ui/pull/1209) @mnajdova
+- Use `FloatingPortalLite` [#1278](https://github.com/mui/base-ui/pull/1278) @atomiks
+
 ## v1.0.0-alpha.4
 
 _Dec 17, 2024_

README.md

@@ -1,6 +1,6 @@
 # Base UI
 
-From the creators of Radix, Floating UI, and Material UI, Base UI is an unstyled UI component library for building accessible user interfaces.
+From the creators of Radix, Floating UI, and Material UI, Base UI is an unstyled UI component library for building accessible user interfaces.
 
 ---
 
@@ -24,12 +24,12 @@ To see the latest updates, check out the [releases](https://base-ui.com/react/ov
 
 ## Team
 
-- Michał Dudak [@michaldudak](https://x.com/michaldudak)
-- James Nelson [@atomiksdev](https://x.com/atomiksdev)
-- Albert Yu [@mj12albert](https://github.com/mj12albert)
-- Colm Tuite [@colmtuite](https://x.com/colmtuite)
-- Marija Najdova [@marijanajdova](https://x.com/marijanajdova)
-- Vlad Moroz [@vladyslavmoroz](https://x.com/vladyslavmoroz)
+- **Colm Tuite** (Radix) [@colmtuite](https://x.com/colmtuite)
+- **Vlad Moroz** (Radix) [@vladyslavmoroz](https://x.com/vladyslavmoroz)
+- **James Nelson** (Floating UI) [@atomiksdev](https://x.com/atomiksdev)
+- **Michał Dudak** (Material UI) [@michaldudak](https://x.com/michaldudak)
+- **Marija Najdova** (Material UI + Fluent UI) [@marijanajdova](https://x.com/marijanajdova)
+- **Albert Yu** (Material UI) [@mj12albert](https://github.com/mj12albert)
 
 ## License
 

SECURITY.md

@@ -0,0 +1,13 @@
+# Security policy
+
+## Supported versions
+
+The versions of the project that are currently supported with security updates.
+
+| Base UI version | Release    | Supported          |
+| --------------: | :--------- | :----------------- |
+|          <1.0.0 | 2024-12-17 | :white_check_mark: |
+
+## Reporting a vulnerability
+
+You can report a vulnerability by contacting us via email at [[email protected]](mailto:[email protected]).

docs/next-env.d.ts

@@ -2,4 +2,4 @@
 /// <reference types="next/image-types/global" />
 
 // NOTE: This file should not be edited
-// see https://nextjs.org/docs/app/building-your-application/configuring/typescript for more information.
+// see https://nextjs.org/docs/app/api-reference/config/typescript for more information.