-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more GPU metrics #414
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #414 +/- ##
==========================================
+ Coverage 66.63% 67.47% +0.84%
==========================================
Files 43 47 +4
Lines 7646 9046 +1400
==========================================
+ Hits 5095 6104 +1009
- Misses 2551 2942 +391
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
I am okay with merging this one, but I believe we will make some big refactor on this code very soon..
} | ||
|
||
async fn get_prometheus_metrics() -> Result<MetricsResponse, NodeMetricsError> { | ||
async fn query_metric(client: &reqwest::Client, query: &str) -> Result<f64, NodeMetricsError> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using a closure syntax is more elegant
Closes #410