Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more GPU metrics #414

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

maschad
Copy link
Member

@maschad maschad commented Feb 15, 2025

Closes #410

@maschad maschad self-assigned this Feb 15, 2025
@maschad maschad marked this pull request as draft February 15, 2025 22:55
@maschad maschad marked this pull request as ready for review February 15, 2025 23:02
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 103 lines in your changes missing coverage. Please review.

Project coverage is 67.47%. Comparing base (b7e8c14) to head (a60a620).
Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
atoma-p2p/src/metrics.rs 0.00% 102 Missing ⚠️
atoma-p2p/src/timer.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
+ Coverage   66.63%   67.47%   +0.84%     
==========================================
  Files          43       47       +4     
  Lines        7646     9046    +1400     
==========================================
+ Hits         5095     6104    +1009     
- Misses       2551     2942     +391     
Files with missing lines Coverage Δ
atoma-p2p/src/timer.rs 0.00% <0.00%> (ø)
atoma-p2p/src/metrics.rs 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

I am okay with merging this one, but I believe we will make some big refactor on this code very soon..

}

async fn get_prometheus_metrics() -> Result<MetricsResponse, NodeMetricsError> {
async fn query_metric(client: &reqwest::Client, query: &str) -> Result<f64, NodeMetricsError> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using a closure syntax is more elegant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics] Collect more fine grained metrics for p2p comms
3 participants